fix: playground error when returning a function declaration VSCODE-669 #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
approved these changes
Jan 28, 2025
src/language/worker.ts
Outdated
| @@ -17,7 +16,7 @@ interface EvaluationResult { | |||
| type: string | null; | |||
| } | |||
|
|
|||
| const getContent = ({ type, printable }: EvaluationResult): Document => { | |||
| const getContent = ({ type, printable }: EvaluationResult): any => { | |||
src/language/worker.ts
Outdated
| ): 'json' | 'plaintext' => { | ||
| const content = getContent(evaluationResult); | ||
|
|
||
| export const getLanguage = (content: any): 'json' | 'plaintext' => { |
There was a problem hiding this comment.
could also potentially be unknown?
There was a problem hiding this comment.
It should default to plaintext if this is not a json. This defines the type of virtual document we open with a playground result.
There was a problem hiding this comment.
was referring to any => unknown, I think we don't know much about the content then right?
There was a problem hiding this comment.
Ah, I see! I thought you were talking about the return type.
alenakhineika
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the last statement in a playground is a function declaration, we would error out with a misleading error claiming the playground services crashed due to OOM. The reality was that we were trying to return a function via the language server protocol, which is not supported and was crashing the language server. This change replaces the printable when it is a function with
undefined.Checklist
Motivation and Context
Types of changes